Conversation
…using Control.MiniMap, Control.Zoomslider, and Control.Pan Leaflet plugins. To use these controls, one has to load the corresponding plugins first. These plugins are not official, but are listed on http://leafletjs.com/plugins.html "Notable Leaflet Plugins" page. If the plugins are not loaded, overview and pan are ignored, and large zoom falls back to small zoom, so nothing changed in this case.
|
What happens if you haven’t loaded the plugins? Giles From: Сковорода Никита Андреевич [mailto:notifications@github.com] Add support for overview, pan, and large zoom controls in Leaflet.core using Control.MiniMap, Control.Zoomslider, and Control.Pan Leaflet plugins. To use these controls, one has to load the corresponding plugins first. These plugins are not official, but are listed on http://leafletjs.com/plugins.html "Notable Leaflet Plugins" page. this.road_tile (and this.satellite_tile) were extended a bit for usage in the MiniMap. You can merge this Pull Request by running git pull https://github.com/ChALkeR/mxn leaflet-controls Or view, comment on, or merge it at: Commit Summary
File Changes
Patch Links: |
|
As I wrote in the pull request description:
|
|
A screenshot. Note that I haven't updated the examples, so you have to add js/css files for plugins to see the change. |
|
Can someone take a look on the pull requests, please? |
|
I think we're all a bit maxed out in our day jobs at the moment; I'll take a look at soon as I can though that's probably going to be towards the end of the week. |
|
Thank you =). |
|
=) |
|
Any news? |
|
Umm. This pull request is not related to auto-loading of the map API scripts. No auto-loading here, this code just uses Control.MiniMap, Control.Zoomslider, and Control.Pan if they are present (already loaded). |
|
yep and if they aren't we might autoload them :-) |
|
From where? |
|
I don't think that auto-loading of map API scripts is a great idea. Various reasons:
|
|
Btw, these plugins are only hosted on Github, and you can't just load things from Github, afaik. One more note: self-hosted versions of the APIs that support self-hosting (openlayers, leaflet, etc) are more secure anyway. |
|
One more question: is it really needed? |
|
As part of the work around Issue #113 and in supporting a whole set of constructor initialisation properties, I'm going to take a look at this now. The pull request as it stands may well not get merged in, as there's been a lot of under-the-hood changes, but support for these Leaflet plugins will be added. |
|
Ok, there is one more issue with this pull request: the workaround at ChALkeR@5888b06#diff-fde6bd57f8f76f08905932effc9ebfe5R166 is not needed anymore with recent plugin versions. Are the changes you were talking about finished? |
|
Hi all. Mapstraction project seems stalled, so I ported my stuff away from it. I'm now using a thin abstraction layer of my own that supports only the minimal set of features that I need (map, controls, markers, geocoding) and only Leaflet/Google/Yandex as backends. I will not update this pull request, so anyone who is interested is welcome to overtake it and notify me, so I will close this one. If you are an owner or a collaborator, you can just close this pull request without further notice when you feel like doing it. |
|
Closing. Reopen if needed. |
3 participants
Add support for overview, pan, and large zoom controls in Leaflet.core using Control.MiniMap, Control.Zoomslider, and Control.Pan Leaflet plugins.
To use these controls, one has to load the corresponding plugins first.
These plugins are not official, but are listed on http://leafletjs.com/plugins.html "Notable Leaflet Plugins" page.
this.road_tile (and this.satellite_tile) were extended a bit for usage in the MiniMap.
If the plugins are not loaded, overview and pan are ignored, and large zoom falls back to small zoom, so nothing was broken (or even changed) in this case.