Skip to content

get-process-heap-flags: use GetProcessHeap - #1184

Merged
mike-hunhoff merged 1 commit into
masterfrom
fix/process-heap-flags
Aug 14, 2026
Merged

get-process-heap-flags: use GetProcessHeap#1184
mike-hunhoff merged 1 commit into
masterfrom
fix/process-heap-flags

Conversation

@williballenthin

@williballenthin williballenthin commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

does not match our test sample because the GetProcessHeap call is split across basic blocks from the access to the field member. fixing that means increasing the scope from bb to function.

image

closes #1183

@williballenthin
williballenthin requested a review from mr-tz August 14, 2026 14:44
@williballenthin
williballenthin marked this pull request as draft August 14, 2026 15:07
@williballenthin

williballenthin commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator Author

i'm not sure that GetProcessHeap returns the same thing as in PEB->ProcessHeap

ah, but ReactOS thinks so:

image

@williballenthin
williballenthin marked this pull request as ready for review August 14, 2026 15:19

@mike-hunhoff mike-hunhoff left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mike-hunhoff
mike-hunhoff merged commit 801a792 into master Aug 14, 2026
9 checks passed
@mike-hunhoff
mike-hunhoff deleted the fix/process-heap-flags branch August 14, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FN: process heap flags

2 participants