internet-latency-collector: wire cloud mode end to end - #4322
Draft
thijsvanemmerik wants to merge 2 commits into
Draft
thijsvanemmerik wants to merge 2 commits into
thijsvanemmerik wants to merge 2 commits into
Conversation
The run command builds a cloud collector and a ClickHouse exporter when a cloud node file is configured, and the four ripeatlas subcommands build the same collector, so clear-measurements and create-measurements act on the set the configured mode owns rather than the exchange set. Without that there is no supported way to list or stop cloud measurements, and no abort handle short of the RIPE web console. The exporter is closed after both loops stop, so its final flush still has records to write.
The main package spans more than one file, so the step builds the package rather than a single file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of measuring latency between AWS regions with the internet latency collector. It can already
measure regions and write to ClickHouse, but nothing joins the two.
This makes
runbuild the region collector and a ClickHouse exporter when it is given a node fileof cloud regions, through
--cloud-node-fileorDZ_ILC_CLOUD_NODE_FILE. With that file it skipsthe ledger keypair, the ledger exporter and the Wheresitup feed, reads its ClickHouse settings from
CLICKHOUSE_*environment variables, optionally runs the migrations first, and flushes the exporteron a 30-second tick, since the exporter has no timer of its own. It closes the exporter after both
loops stop, so the final flush still has records. Without the file, every path is as before.
The three
atlassubcommands that list, create and clear measurements now take the same node fileand build the same collector, so each acts on the measurements the configured mode owns. Before
this they always built the collector for DoubleZero exchange locations, so
clear-measurementswitha node file configured would have deleted the wrong set.
The Dockerfile also builds this collector into the core image, which did not build it at all, so
merging adds that one binary. Nothing else changes: the new mode turns on only with a node file,
which only a separate deployment supplies, and that does not exist yet.
Test:
go test ./controlplane/internet-latency-collector/cmd/collector/...