internet-latency-collector: add cloud region mode, off by default - #4315
Draft
thijsvanemmerik wants to merge 1 commit into
Draft
thijsvanemmerik wants to merge 1 commit into
thijsvanemmerik wants to merge 1 commit into
Conversation
The collector measures DoubleZero exchanges by discovering RIPE Atlas probes near each one. A cloud node file switches it to measuring the cloud regions the file names, using the probes the file pins. Config.Validate now accepts a RIPE Atlas only configuration, so Run guards both collectors against nil. With no node file given the run wiring is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of measuring latency between AWS regions with the internet latency collector.
The collector takes the places it measures from the DoubleZero ledger and always runs both of its
measurement providers, so it cannot be pointed at a list of cloud regions instead. This adds a
--cloud-node-fileflag, with aDZ_ILC_CLOUD_NODE_FILEenvironment variable behind it, thatswitches
runto read its places from that JSON node file and use RIPE Atlas alone.Config validation and the run loop used to require both providers. They now accept either one being
absent, and reject a Wheresitup provider when a node file is set. The node file is the only switch.
Nothing changes in production. Neither the flag nor the variable is set there, so the collector
takes the same path as today. The node file is supplied only by a separate deployment, which does
not exist yet.
Test:
go test ./controlplane/internet-latency-collector/.... No Docker needed.