Repository navigation
Conversation
The product widget preview templates called Magento\Wishlist\Helper\Data directly, so rendering them fails when Magento_Wishlist is not installed, even though this module doesn't depend on it. Use $block->isAddToWishlistAllowed(), which Magento_Catalog provides and which returns false without Magento_Wishlist. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The product widget preview templates call
Magento\Wishlist\Helper\Datadirectly, so they fail to render without Magento_Wishlist, which this module doesn't depend on. They now use$block->isAddToWishlistAllowed(), which returns false when Magento_Wishlist isn't installed.Depends on mage-os/mageos-magento2#396, which adds
isAddToWishlistAllowed()toMagento\Catalog\Block\Product\AbstractProduct. This is part of the series that makes Magento_Wishlist removable.Test: the New Products and Catalog Products List widget previews in Page Builder show "Add to Wish List" as before.
🤖 Generated with Claude Code