Skip to content

Remove HTML escaping for repeatable items - #18

Merged
rhoerr merged 2 commits into
mage-os:masterfrom
yuriy-boyko:master
May 31, 2026
Merged

rhoerr merged 2 commits into
mage-os:masterfrom
yuriy-boyko:master

Conversation

@yuriy-boyko

Copy link
Copy Markdown
Contributor

Remove HTML escaping for repeatable items data in widget, escaped HTML breaks internal JSON encoding when using HTML inside fields

see vendor/magento/module-widget/Helper/Conditions.php -> encode()

… breaks internal JSON encoding when using HTML inside fields
@yuriy-boyko
yuriy-boyko requested review from a team and dadolun95 as code owners March 16, 2026 16:13
@rhoerr

rhoerr commented May 15, 2026

Copy link
Copy Markdown
Member

@SamueleMartini Can you take a look at this? Thanks!

@SamueleMartini

Copy link
Copy Markdown
Contributor

@dadolun95 puoi revisionare?

dadolun95
dadolun95 previously approved these changes May 30, 2026

@dadolun95 dadolun95 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@rhoerr
rhoerr merged commit 95a2ced into mage-os:master May 31, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants