[mark-cooper]

No description provided.

[kspurgin]

@mark-cooper - confirmed that I've seen this and am testing with our tooling. I've also checked with Olivia re: whether this will impact any of the scripts she's using for active migrations.

Question/concern:

Version is being bumped from 0.4.2 to 0.5.0, but this is a breaking change if you have any scripts that relied on the base_repo setting and then used any of the convenience methods that used that setting and now use context. Example: The following would work with the existing client version, with base_repo set to 2, but it breaks here:

[6] pry(main)> c.resources.each { |r| puts r["uri"] }
TypeError: no implicit conversion of String into Integer (TypeError)
from (pry):6:in 'block in __pry__'

Shouldn't this version be 1.0.0 since this is a major breaking change requiring code updates in some cases?

Request going forward:

Can actual code changes be in a separate commit with Rubocop style fixes? It is hard to see what actually changed in terms of functionality in this PR because there's so much functionally irrelevant style stuff in this commit.

[mark-cooper]

We have a meeting coming up so will discuss more thoroughly there. I don't see that there are any lint only fixes though. But I'll look through it again.

[kspurgin]

Mark clarified the version numbering on this project is not intended to adhere to SemVer, so I'm approving.