Made example contents working as expected and visible#575
Open
rabinadk1 wants to merge 4 commits into
Open
Conversation
* Change pygmentsStyle from bw to b2 to make it more readable in dark mode * Add ability to insert html inside of markdowns * `math: true` uses mathjax. So use `katex:true` instead
luizdepra
reviewed
Jun 22, 2021
| url = "contact/" | ||
|
|
||
| # Enable html support inside markdown | ||
| [markup] |
Owner
There was a problem hiding this comment.
Everything looks fine. I'm only against this addition. This is not a mandatory configuration for this theme.
Please, could you remove it?
Contributor
Author
There was a problem hiding this comment.
Removing it will not render the blog posts provided correctly.
Contributor
Author
There was a problem hiding this comment.
- This section doesn't work as intended. https://hugo-coder.netlify.app/posts/markdown-syntax/#other-elements--abbr-sub-sup-kbd-mark
- This section doesn't show the photo. https://hugo-coder.netlify.app/posts/placeholder-text/#vagus-elidunt
- And, this doesn't show emoji at all. https://hugo-coder.netlify.app/posts/emoji-support/
Contributor
There was a problem hiding this comment.
Yes, I met the same problem thought it is not a big deal.
Owner
There was a problem hiding this comment.
I forgot to come back here.
- About the 'abbr, sub, sup, kbd, mark' no styling, this should be just missing CSS rules.
- The SVG file should be added with a shortcode. I don't know if there is a default one with Hugo, if not I can build one later.
- Emoji should be working. Maybe we are using an old version of Hugo to build the preview. I'm going to take a look on that issue.
4 tasks
Make following posts work as intended. - emoji-support - placeholder-text
Contributor
Author
|
Now, the following posts also support inline CSS.
|
ccviolett
reviewed
Jan 17, 2022
ccviolett
left a comment
ccviolett
left a comment
Contributor
There was a problem hiding this comment.
It is more safer to implement CSP when put in use. It just need some introduction about it.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Put an
xinto the box(es) that apply:Description
pygmentsStylefrom bw to b2 to make it more readable in darkmode
math: trueuses mathjax. So usekatex:trueinsteadconfig.tomlIssues Resolved
config.tomlhelps in checking the code during pull requestsChecklist
Put an
xinto the box(es) that apply:General
#<ISSUE_NO>if applicableResources
make releaseto regenerate all CSS filesContributors
CONTRIBUTORS.mdif you aren't on it already