Repository navigation
content-type comparison is failing #2
Description
Hi,
In my case https://github.com/luca-moser/iris-cache/blob/master/cache.go#L119 failed, because my Content-type contains my encoding: Content-Type: text/html; charset=UTF-8
Therefore I can't use your provided values for content type (cache.ContentTypeHTML/cache.ContentTypeJSON)
Could you fix it somehow? For example trim the variable after ;. It's not a big deal, but it could be better with a fix.
Activity
luca-moser commentedon Dec 6, 2017
The
ContentTypeconstants are merely the same values as used by iris (iris repo link).With the
Configstruct, you are able to set a customContentTypewhich should be cached (link).So in your case supplying a
ConfigtoNewCacheHForNewCachewith a customContentTypeof"text/html; charset=UTF-8"should fix your issue.I think it's faster when the user of the middleware supplies his/her used content types, since otherwise the middleware would have to do trimming and whatnot.
dh-harald commentedon Dec 6, 2017
I know, I'm already using that method, you suggested... (that was my workaround)
I've opened this ticket, because based on the documentation, the middleware couldn't working in special circumstances (eg. it's not caching anything).
Just because of nature of Content-Type header, you could easily trim it after
;, and the content type values could work afterwards...