fix(tests): skip nanos test on non-Linux (APFS lacks precision) - #1226
Open
MeGaurav4 wants to merge 1 commit into
Open
fix(tests): skip nanos test on non-Linux (APFS lacks precision)#1226MeGaurav4 wants to merge 1 commit into
MeGaurav4 wants to merge 1 commit into
Conversation
The test_date_custom_format_supports_nanos_with_length test relies on sub-millisecond filesystem timestamps, which APFS (macOS) does not expose. Add #[cfg(target_os = "linux")] to match the existing pattern for platform-dependent tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1223. Skips
test_date_custom_format_supports_nanos_with_lengthon non-Linux platforms where the filesystem does not expose sub-millisecond timestamp precision (APFS on macOS). Uses the same#[cfg(target_os = "linux")]pattern already established in this file.Test passes on Linux (1/1). On macOS the test will be silently skipped.
Verification
cargo test test_date_custom_format_supports_nanos_with_lengthpasses on Linux