Skip to content

Regenerate expected fixtures for libvips v8.17.0#4402

Merged
lovell merged 1 commit into
lovell:mainfrom
kleisauke:vips-8.17
Jun 8, 2025
Merged

Regenerate expected fixtures for libvips v8.17.0#4402
lovell merged 1 commit into
lovell:mainfrom
kleisauke:vips-8.17

Conversation

@kleisauke

@kleisauke kleisauke commented May 28, 2025

Copy link
Copy Markdown
Contributor

Regenerate extract.tiff to avoid an test failure due to PR libvips/libvips#4313.

$ curl -LO https://github.com/lovell/sharp/raw/v0.34.2/test/fixtures/expected/extract.tiff
$ vips copy extract.tiff[fail-on=warning] x.jpg 

(vips:22733): tiff2vips-WARNING **: 14:54:38.286: The JPEG strip/tile is encoded with progressive mode, which is normally not legal for JPEG-in-TIFF.
libtiff should be able to decode it, but it might cause compatibility issues with other readers

(vips:22733): VIPS-WARNING **: 14:54:38.287: error in tile 0 x 0

@lovell

lovell commented May 30, 2025

Copy link
Copy Markdown
Owner

Thanks Kleis, your suggested change for the TIFF extraction test looks good. For the composite tests, does forcing a higher PNG bitdepth for both the expected and actual fixtures via something like .toColourspace('rgb16') help?

@kleisauke

Copy link
Copy Markdown
Contributor Author

For the composite tests, does forcing a higher PNG bitdepth for both the expected and actual fixtures via something like .toColourspace('rgb16') help?

This didn't help. I've opened PR libvips/libvips#4547 to avoid that change.

@lovell lovell mentioned this pull request Jun 5, 2025
21 tasks
@kleisauke kleisauke changed the title Regenerate expected fixtures for future libvips v8.17.0 Regenerate expected fixtures for libvips v8.17.0 Jun 8, 2025
@kleisauke kleisauke marked this pull request as ready for review June 8, 2025 10:44
@lovell lovell merged commit 91f1b58 into lovell:main Jun 8, 2025
24 checks passed
@lovell

lovell commented Jun 8, 2025

Copy link
Copy Markdown
Owner

Thank you Kleis.

@kleisauke kleisauke deleted the vips-8.17 branch June 9, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants