Repository navigation
update invalidate tests to the matched-count reply, fix formatting - #351
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the two CI failures the merged stack left on main; both were known from the stack branches' runs and are test-side only.
Unit: five js tests pinned the old invalidate reply. The
/__oj_invalidateprotocol changed with the gate: a change invalidation now answers 200 with{matched: n|null}(how many changes matched a runner-backed graph; null when the walk threw) so the caller can skip the reload on a miss, while a resync keeps its 204 enqueue-ACK. Five tests acrosscf-environment-api.test.mjsandinvalidate-canonical.test.mjsstill asserted 204 on change invalidations. They now assert 200 and the reply shape; the canonical-spelling test pins{matched: 1}exactly, since its one symlink-spelled change must resolve to the one canonically keyed module. The resync assertions stay at 204, which is the contract.