Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"@lokalise/biome-config": "^2.0.0",
"@types/node": "^25.0.2",
"@types/tmp": "^0.2.6",
"@vitest/coverage-v8": "^3.2.4",
"@vitest/coverage-v8": "^4.1.8",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify compatibility contract directly from npm metadata (read-only).
set -euo pipefail

echo "Current package.json entries:"
rg -n '"`@vitest/coverage-v8`"|"vitest"' package.json

echo
echo "`@vitest/coverage-v8`@4.1.8 peerDependencies:"
npm view `@vitest/coverage-v8`@4.1.8 peerDependencies --json

echo
echo "vitest@3.2.4 version check:"
npm view vitest@3.2.4 version

echo
echo "If peerDependencies require vitest ^4, this PR should either:"
echo "  1) bump vitest to a compatible ^4.x in same PR, or"
echo "  2) keep `@vitest/coverage-v8` on a ^3.x compatible line."

Repository: lokalise/node-core

Length of output: 503


Fix Vitest coverage plugin peerDependency mismatch
package.json pins @vitest/coverage-v8 to ^4.1.8, whose peerDependencies require vitest: 4.1.8, but vitest is still ^3.2.4 (lines 52 and 58). This can break install/coverage in CI.
Update either by bumping vitest to a compatible ^4.1.8 (or matching 4.x) or by downgrading @vitest/coverage-v8 to the ^3.x compatible line.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@package.json` at line 52, The package.json currently has a peerDependency
mismatch: `@vitest/coverage-v8` is pinned to ^4.1.8 while vitest remains ^3.2.4.
Fix by making the versions compatible — either bump the vitest devDependency to
a 4.x series (e.g., ^4.1.8 or ^4.x) to match `@vitest/coverage-v8`, or downgrade
`@vitest/coverage-v8` to a 3.x release that is compatible with vitest ^3.2.4;
update the corresponding version string for the "vitest" or
"`@vitest/coverage-v8`" entries in package.json and run npm/yarn install to verify
there are no peerDependency conflicts.

"auto-changelog": "^2.4.0",
"pino-test": "^2.0.0",
"tmp": "^0.2.4",
Expand Down
Loading