ci: convert release builder to workflow_dispatch (v0.36)#4098
Merged
sydorovdmytro merged 1 commit intoJul 21, 2026
Conversation
Builder-only conversion of the vCluster release pipeline for the v0.36
legacy line, matching the v0.31-v0.35 siblings (DEVOPS-1050).
- Drop the release:created trigger; the workflow is dispatched via
workflow_dispatch --ref <tag>, so github.ref/github.ref_name carry the
version.
- Decouple github.event.release.tag_name -> github.ref_name in
check_minimum_version_tag and the failure notification.
- Derive previous_tag from branch-local history
(git describe --match 'v*' "${GITHUB_SHA}^") instead of the global
latest tag, which is wrong on a release branch.
No post-build validation wired (legacy line; matches current behavior).
E2E Ginkgo Tests
|
sydorovdmytro
marked this pull request as ready for review
July 21, 2026 14:00
Piotr1215
approved these changes
Jul 21, 2026
sydorovdmytro
deleted the
dmytrosydorov/devops-1050-release-dispatch-v0.36
branch
July 21, 2026 14:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the DEVOPS-1050 phase-4 fan-out (loft-sh/vcluster legacy line). Builder-only conversion, sibling to vcluster#4073–#4077 (v0.31–v0.35).
What
Converts only the builder
release.yaml:release:createdtrigger; the workflow is dispatched viaworkflow_dispatch --ref <tag>, sogithub.ref/github.ref_namecarry the version.github.event.release.tag_name→github.ref_nameincheck_minimum_version_tagand the failure Slack notification.previous_tagfrom branch-local history (git describe --tags --abbrev=0 --match 'v*' "${GITHUB_SHA}^") instead ofgit rev-list --tags --skip=1, which picks the global latest tag (wrong on a release branch).Validators intentionally unchanged
Legacy lines get no post-build validation wired — matches current behavior (no regression). Release validation for new lines (
>= v0.37) is handled bymain's tag-dispatched validators (reference PR vcluster#4072).v0.36 is still the old (pre-monorepo) layout, so this is identical to the v0.35 conversion (#4073) apart from a pre-existing base delta (
linear-release-synctag bump) the conversion does not touch.Actionlint-clean. Draft to match the sibling PRs.
Note
Medium Risk
Changes how production releases are triggered and how Goreleaser’s previous tag is chosen; mis-dispatch or a bad previous_tag could block releases or skew release notes, but no app runtime or security paths are touched.
Overview
Part of DEVOPS-1050: the
release.yamlbuilder no longer runs onrelease:created. It is started withgh workflow run release.yaml --ref <tag>, so the version comes fromgithub.ref/github.ref_nameinstead ofgithub.event.release.tag_name(minimum-version check, checkout ref, failure Slack notify).previous_tagis now computed withgit describefrom${GITHUB_SHA}^on the current branch, replacing the global “second-latest tag” lookup so Goreleaser’sGORELEASER_PREVIOUS_TAG/ changelog baseline is correct on release branches.Comments document that the GitHub Release is produced at the end of a green build, avoiding monorepo OSS releases re-firing this workflow.
Reviewed by Cursor Bugbot for commit b8ad370. Bugbot is set up for automated code reviews on this repo. Configure here.