ci: convert release builder to workflow_dispatch (v0.31)#4077
Draft
sydorovdmytro wants to merge 2 commits into
Draft
ci: convert release builder to workflow_dispatch (v0.31)#4077sydorovdmytro wants to merge 2 commits into
sydorovdmytro wants to merge 2 commits into
Conversation
Convert the release builder to workflow_dispatch (the GitHub Release is now a pipeline output created by goreleaser, not a trigger) and drive e2e and unit-test validation off workflow_run of the Release builder completing. On the release path change detection is skipped, jobs run only for a green build, and the built tag is checked out. Previous-tag derivation is made branch-local. Closes DEVOPS-1050
Legacy lines keep their existing validators untouched: release validation is handled by main's workflow_run validators, gated to new (>= v0.37) lines. This branch only converts the builder release.yaml (release-as-output + dispatch).
sydorovdmytro
changed the title
sydorovdmytro
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the DEVOPS-1050 phase-4 fan-out (loft-sh/vcluster legacy line). Builder-only conversion.
What
Converts only the builder
release.yaml:on: release:[created]→on: workflow_dispatch(release-as-output: goreleaser creates the release at the end of a green build, dispatched by the sharedvcluster-releaseaction via--ref <tag>).github.event.release.*→github.ref_name.previous_tag(git describe --match 'v*' <sha>^).Validators intentionally unchanged
Legacy lines get no post-build validation wired — this matches current behavior (no regression).
workflow_runonly ever fires from the default branch, so a legacy-branch validator trigger would never fire anyway. Release validation for new lines (>= v0.37) is handled bymain's validators, gated to skip legacy tags (reference PR #4072).Actionlint-clean. Draft until the GitHub Actions incident clears and CI can run.