ci: convert release builder to workflow_dispatch (v0.35)#4073
Merged
sydorovdmytro merged 2 commits intoJul 21, 2026
Conversation
Convert the release builder to workflow_dispatch (the GitHub Release is now a pipeline output created by goreleaser, not a trigger) and drive e2e, unit-test and ginkgo validation off workflow_run of the Release builder completing. On the release path change detection is skipped, jobs run only for a green build, and the built tag is checked out. Previous-tag derivation is made branch-local. Closes DEVOPS-1050
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
E2E Ginkgo Tests
|
Legacy lines keep their existing validators untouched: release validation is handled by main's workflow_run validators, gated to new (>= v0.37) lines. This branch only converts the builder release.yaml (release-as-output + dispatch).
sydorovdmytro
changed the title
sydorovdmytro
changed the title
sydorovdmytro
marked this pull request as ready for review
July 21, 2026 14:00
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c519466. Configure here.
Piotr1215
approved these changes
Jul 21, 2026
sydorovdmytro
deleted the
dmytrosydorov/devops-1050-release-dispatch-v0.35
branch
July 21, 2026 14:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the DEVOPS-1050 phase-4 fan-out (loft-sh/vcluster legacy line). Builder-only conversion.
What
Converts only the builder
release.yaml:on: release:[created]→on: workflow_dispatch(release-as-output: goreleaser creates the release at the end of a green build, dispatched by the sharedvcluster-releaseaction via--ref <tag>).github.event.release.*→github.ref_name.previous_tag(git describe --match 'v*' <sha>^).Validators intentionally unchanged
Legacy lines get no post-build validation wired — this matches current behavior (no regression).
workflow_runonly ever fires from the default branch, so a legacy-branch validator trigger would never fire anyway. Release validation for new lines (>= v0.37) is handled bymain's validators, gated to skip legacy tags (reference PR #4072).Actionlint-clean. Draft until the GitHub Actions incident clears and CI can run.
Note
Medium Risk
Touches the production release entrypoint and goreleaser tag inputs; behavior now depends on dispatch with the correct tag ref instead of the release event.
Overview
Release builder no longer runs on
release: created; it is started only viaworkflow_dispatch(expected from the sharedvcluster-releaseaction with--ref <tag>), so the GitHub Release from goreleaser is an output and cannot re-trigger the workflow.Checkout, minimum-version checks, and failure notifications now use
github.ref_nameinstead ofgithub.event.release.tag_name.previous_tagfor goreleaser is computed from the tag on the commit’s parent on the current branch (git describe … "${GITHUB_SHA}^"), replacing the repo-wide “second newest tag” logic so release-branch builds get the correct prior version.Reviewed by Cursor Bugbot for commit c519466. Bugbot is set up for automated code reviews on this repo. Configure here.