fix(config): scope library/ prefix to Docker Hub#4022
Open
louis-kauer wants to merge 1 commit into
Open
Conversation
library/ prefix to Docker Hub
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address?
/kind bugfix
What does this pull request do? Which issues does it resolve?
resolves #4021
Gates the
library/namespace injection inImage.String()on the registry actually being Docker Hub (docker.ioorindex.docker.io). Previously, any non-empty registry plus a slashless repository gotlibrary/prepended, producing invalid references likeghcr.io/library/alpine:3.20. Round-trip viaParseImageRefis preserved.Please provide a short message that should be published in the vcluster release notes
What else do we need to know?
Tests pass locally (
go test ./config/...). Updates one existing test case (omit repo but not registry is library) that encoded the bug as expected output, plus six new cases covering Docker Hub canonical/alias and non-Docker-Hub registries. No API or config changes.E2E Tests
Default Test Execution
The mandatory PR suite runs automatically. Only specify additional test suites below if needed.
Additional test suites