fix(storageclasses): log storage class name instead of struct pointer#3968
Open
chemicoholic21 wants to merge 3 commits into
Open
fix(storageclasses): log storage class name instead of struct pointer#3968chemicoholic21 wants to merge 3 commits into
chemicoholic21 wants to merge 3 commits into
Conversation
The host storage class syncer passed the whole *storagev1.StorageClass value to a %s verb when logging a deletion, producing an unreadable struct/pointer dump instead of the object name. Use event.Virtual.Name, matching the sibling csistoragecapacities syncer. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
seanschneeweiss
approved these changes
Jun 3, 2026
Contributor
|
@chemicoholic21 thanks for the contribution. Can you rebase the change to keep a linear history without merge commits? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The host storage class syncer passed event.Virtual (a *storagev1.StorageClass) to a %s verb, dumping the whole struct instead of the name. Fixed to use event.Virtual.Name, matching the sibling csistoragecapacities syncer.