Expose MinimumAreaRectangle convex-hint API (#1149)#1217
Open
grootstebozewolf wants to merge 1 commit into
Open
Expose MinimumAreaRectangle convex-hint API (#1149)#1217grootstebozewolf wants to merge 1 commit into
grootstebozewolf wants to merge 1 commit into
Conversation
The convex-hint constructor was unusable because getMinimumRectangle was private and the static factory ignored isConvex. Make the instance method public and add getMinimumRectangle(Geometry, boolean), matching MinimumDiameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getMinimumRectangle()public so the convex-hint constructor is usable.getMinimumRectangle(Geometry, boolean isConvex)so callers can skip convex-hull computation when the input is already known to be convex.MinimumDiameterfor the instance path (see MinumumAreaRectangle with convex hint is limited because all methods are private #1149).Test plan
mvn -pl modules/core test -Dtest=MinimumAreaRectanglelTest— 12 tests, 0 failurestestConvexHintStaticAndInstancechecks static+instance convex paths match the default path on a convex polygonFixes #1149