GEOMESA-3579 Add SpatialFillingCurves Java-interop functionality to geomesa#3580
Open
cwdobbins wants to merge 1 commit into
Open
GEOMESA-3579 Add SpatialFillingCurves Java-interop functionality to geomesa#3580cwdobbins wants to merge 1 commit into
cwdobbins wants to merge 1 commit into
Conversation
…eomesa-z3 and leverage it in geomesa-trino-plugin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates geomesa-trino plugin's Scala
SfcBridgetoorg.locationtech.geomesa.curve.interop.SpaceFillingCurvesin geomesa-z3 — a Java-friendly facade overZ2SFC/XZ2SFC— mirroring a pre-existing GeoMesa code convention, centralizing SFC-related code in the geomesa-z3 core library, enabling re-use across modules, and removing SDK dependency from geomesa-trino-plugin, allowing it to be a pure-Java module.Motivation
The SfcBridge scala class was built to support the development of the geomesa-trino-plugin, to present a Java-friendly facade over Z2SFC/XZ2SFC methods, whose signatures Java could not consume. Hosting the facade in geomesa-z3 makes it available to any JVM consumer and removes the one and only Scala source code from the Trino plugin module.
Changes
geomesa-z3
org.locationtech.geomesa.curve.interop.SpaceFillingCurves:z2Index/z2Hex/z2HexRanges,xz2Index/xz2Hex/xz2HexRanges.HexRange(lower, upper)case class as the Java-nameable analogue ofIndexRange; range methods returnjava.util.List<HexRange>.Z2SFC.hexEncode/XZ2SFC.hexEncodewhich produces left-shifted lexographically-comparable strings: assures index/hex parity with the underlying SFCs, clamping, range coverage of indexed values, and themaxRanges` bound.geomesa-trino-plugin
SfcBridge.scalaremoved; call sites use the new facade and the typedHexRangesrc/main/scalaremoved, directscala-librarydependency dropped (still bundled transitively in the shaded jar),scala-maven-pluginconfiguration removed.No behavioral changes.
Testing
mvn -pl geomesa-z3 -pl geomesa-trino/geomesa-trino-plugin -pl geomesa-trino/geomesa-trino-datastore clean install