Skip to content

Add new metrics for sdp negotiation - #773

Merged
genseric-ghiro merged 3 commits into
mainfrom
gensericghiro/add-new-metrics-for-sdp-negotation
Aug 4, 2026
Merged

Add new metrics for sdp negotiation#773
genseric-ghiro merged 3 commits into
mainfrom
gensericghiro/add-new-metrics-for-sdp-negotation

Conversation

@genseric-ghiro

Copy link
Copy Markdown
Contributor

Summary

  • Adding two new metrics (sdpParsed, codecOffered) to record when an SDP negotiation takes place, and what codecs are offered. This is only for inbound calls as the set of offered codecs for outbound calls is always the same (and the answer only contains what the user picked, and not what they support)
  • Adding the provider label to these two metrics. The goal is to extend this tag to all the existing metrics (where applicable in a follow-up).

Testing

  • New tests in media_port, media_codecs and inbound

@genseric-ghiro genseric-ghiro self-assigned this Aug 3, 2026
@genseric-ghiro
genseric-ghiro requested a review from a team as a code owner August 3, 2026 20:11
@CLAassistant

CLAassistant commented Aug 3, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@dennwc dennwc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@genseric-ghiro
genseric-ghiro merged commit 8a8f07f into main Aug 4, 2026
7 checks passed
@genseric-ghiro
genseric-ghiro deleted the gensericghiro/add-new-metrics-for-sdp-negotation branch August 4, 2026 13:06
@genseric-ghiro genseric-ghiro changed the title Gensericghiro/add new metrics for sdp negotation Gensericghiro/add new metrics for sdp negotiation Aug 4, 2026
@genseric-ghiro genseric-ghiro changed the title Gensericghiro/add new metrics for sdp negotiation Add new metrics for sdp negotiation Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants