handle late reconnect responses - #2077
Closed
lukasIO wants to merge 6 commits into
Closed
Conversation
🦋 Changeset detectedLatest commit: cabd0df The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
lukasIO
changed the title
lukasIO
marked this pull request as ready for review
September 1, 2026 15:43
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| }); | ||
| // The new node's ICE servers can't wait for the resume to finish: without them we'd keep | ||
| // the previous node's TURN credentials, which can fail the ICE restart outright. | ||
| this.applyReconnectResponse(res); |
Contributor
There was a problem hiding this comment.
🔴 Failed late ICE restart reports success
When triggerIceRestart rejects, updateConfiguration only logs the failure while the active resume continues. The client can report reconnection with unusable ICE credentials.
Was this helpful? React with 👍 or 👎 to provide feedback.
…sdk-js into lukas/late-reconnect-res
1egoman
approved these changes
Sep 1, 2026
Contributor
Author
|
superseded by #2082 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ensures that during a reconnect a ReconnectResponse arrives after some other signalling message, the ReconnectResponse still gets applied retroactively.