fix npm run lint on Windows#25
Conversation
`npm run lint` fails because eslint does not like the `'`s wrapping its target path. Removing the single quotes fixes `npm run lint`
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
Why doesn't work for you with the |
|
It may be an environment thing, certainly running |
|
I've just confirmed this is only an issue on my Windows rig, on my Mac all is well |
|
The fix in this PR is compatible with both of my machines, but I'll leave this to your discretion |
|
Got it, you are right! Windows issue! |
abdonrd
left a comment
There was a problem hiding this comment.
With this, should work both!
Add <xliff> element, remove prettier formatting, release
|
Should I close this PR? |
npm run lintfails because eslint does not like the's wrapping its target path. Removing the single quotes fixesnpm run lint