Skip to content

fix npm run lint on Windows#25

Open
johnstonmatt wants to merge 1 commit into
lit:mainfrom
johnstonmatt:patch-4
Open

fix npm run lint on Windows#25
johnstonmatt wants to merge 1 commit into
lit:mainfrom
johnstonmatt:patch-4

Conversation

@johnstonmatt

Copy link
Copy Markdown

npm run lint fails because eslint does not like the 's wrapping its target path. Removing the single quotes fixes npm run lint

`npm run lint` fails because eslint does not like the `'`s wrapping its target path. Removing the single quotes fixes `npm run lint`
@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@johnstonmatt

Copy link
Copy Markdown
Author

@googlebot I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@abdonrd

abdonrd commented Jun 10, 2020

Copy link
Copy Markdown
Contributor

Why doesn't work for you with the '?
I use it in a lot of projects and works well.

@johnstonmatt

johnstonmatt commented Jun 10, 2020

Copy link
Copy Markdown
Author

It may be an environment thing, certainly running npm run lint fails for this reason on my machine

@johnstonmatt

johnstonmatt commented Jun 10, 2020

Copy link
Copy Markdown
Author

I've just confirmed this is only an issue on my Windows rig, on my Mac all is well

@johnstonmatt

Copy link
Copy Markdown
Author

The fix in this PR is compatible with both of my machines, but I'll leave this to your discretion

@abdonrd

abdonrd commented Jun 10, 2020

Copy link
Copy Markdown
Contributor

Got it, you are right! Windows issue!

@abdonrd abdonrd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this, should work both!

Comment thread package.json
@johnstonmatt johnstonmatt changed the title remove quotes wrapping eslint path fix npm run lint on Windows Aug 11, 2020
kevinpschaaf pushed a commit that referenced this pull request Jan 6, 2021
Add <xliff> element, remove prettier formatting, release
@johnstonmatt

Copy link
Copy Markdown
Author

Should I close this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants