Skip to content

libnvme: rewrite the discovery walk as a depth-capped, deduped walker #3837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igaw merged 6 commits into from
Aug 14, 2026
Merged

libnvme: rewrite the discovery walk as a depth-capped, deduped walker #3837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b2b0630
libnvme: guard three unchecked fabrics hook calls against NULL
Aug 13, 2026
b7a6aa3
nvme, libnvme: rename discover/connect-all --force to --no-reuse
Aug 13, 2026
17dc3a3
libnvme: use a Discovery Descriptor's own NQN when specified
Aug 13, 2026
3293595
libnvme: unify discovery ctrl lookup-or-create into dc_open()
Aug 13, 2026
1bfd9a1
libnvme: rewrite _nvmf_discover() as a depth-capped, deduped walk
Aug 13, 2026
bc0ffbc
libnvme: fold NBFT discovery onto the shared walker
Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Documentation/nvme-connect-all.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ SYNOPSIS
[--config=<filename> | -J <cfg>]
[--persistent[=<no|auto|force>] | -p]
[--quiet]
[--no-reuse]
[--nbft]
[--no-nbft]
[--nbft-path=<STR>]
Expand Down Expand Up @@ -86,6 +87,9 @@ OPTIONS
--quiet::
Suppress error messages.

--no-reuse::
Always create a new connection, never reuse an existing one.

--nbft::
Only look at NBFT tables

Expand Down
8 changes: 5 additions & 3 deletions Documentation/nvme-discover.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ SYNOPSIS
[--config=<filename> | -J <filename>]
[--persistent[=<no|auto|force>] | -p]
[--quiet]
[--no-reuse]
[--force]
[--nbft]
[--no-nbft]
Expand Down Expand Up @@ -107,10 +108,11 @@ OPTIONS
--quiet::
Suppress already connected errors.

--no-reuse::
Always create a new connection, never reuse an existing one.

--force::
Disable the built-in persistent discovery controller connection
rules. Combined with --persistent flag, always create new
persistent discovery controller connection.
(deprecated, see --no-reuse)

--nbft::
Only look at NBFT tables
Expand Down
4 changes: 2 additions & 2 deletions libnvme/src/accessors-fabrics.ld
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ LIBNVMF_ACCESSORS_3 {
libnvmf_context_get_disable_sqflow;
libnvmf_context_get_duplicate_connect;
libnvmf_context_get_fast_io_fail_tmo;
libnvmf_context_get_force;
libnvmf_context_get_hdr_digest;
libnvmf_context_get_host_iface;
libnvmf_context_get_host_traddr;
Expand All @@ -40,6 +39,7 @@ LIBNVMF_ACCESSORS_3 {
libnvmf_context_get_keyring;
libnvmf_context_get_keyring_id;
libnvmf_context_get_nbft_path;
libnvmf_context_get_no_reuse;
libnvmf_context_get_nr_io_queues;
libnvmf_context_get_nr_poll_queues;
libnvmf_context_get_nr_write_queues;
Expand All @@ -64,11 +64,11 @@ LIBNVMF_ACCESSORS_3 {
libnvmf_context_set_disable_sqflow;
libnvmf_context_set_duplicate_connect;
libnvmf_context_set_fast_io_fail_tmo;
libnvmf_context_set_force;
libnvmf_context_set_hdr_digest;
libnvmf_context_set_keep_alive_tmo;
libnvmf_context_set_keyring_id;
libnvmf_context_set_nbft_path;
libnvmf_context_set_no_reuse;
libnvmf_context_set_nr_io_queues;
libnvmf_context_set_nr_poll_queues;
libnvmf_context_set_nr_write_queues;
Expand Down
Loading
Loading