Skip to content

Update lancedb requirement from <0.30.0 to <0.34.0 - #936

Closed
dependabot[bot] wants to merge 2 commits into
mainfrom
dependabot/pip/lancedb-lt-0.34.0
Closed

dependabot[bot] wants to merge 2 commits into
mainfrom
dependabot/pip/lancedb-lt-0.34.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jun 1, 2026 •

Copy link
Copy Markdown
Contributor

Updates the requirements on lancedb to permit the latest version.

Release notes

Sourced from lancedb's releases.

Python LanceDB v0.33.0

🛠 Breaking Changes

🎉 New Features

🐛 Bug Fixes

📚 Documentation

🔧 Build and CI

Commits
  • c0a9a4d ci: fix pypi publish on mac/windows/arm (#3449)
  • 32c3d39 Bump version: 0.30.0-beta.2 → 0.30.0
  • 7a41f4a Bump version: 0.30.0-beta.1 → 0.30.0-beta.2
  • 28fc8f0 Bump version: 0.33.0-beta.2 → 0.33.0
  • 7677a52 Bump version: 0.33.0-beta.1 → 0.33.0-beta.2
  • b6c6455 chore: update lance dependency to v7.0.0
  • a9f49c8 fix: allow appending arrow.json data into lance.json tables (#3429)
  • a7d9f2e fix: remove primary key constraint from MemWAL bucket sharding (#3435)
  • 7dba793 fix(rerankers): inverted scores and incorrect missing-FTS penalty in LinearCo...
  • 87bd669 chore(deps): bump the rust-minor-patch group across 1 directory with 2 update...
  • Additional commits viewable in compare view

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Jun 1, 2026
Updates the requirements on [lancedb](https://github.com/lancedb/lancedb) to permit the latest version.
- [Release notes](https://github.com/lancedb/lancedb/releases)
- [Changelog](https://github.com/lancedb/lancedb/blob/main/release_process.md)
- [Commits](lancedb/lancedb@v0.0.2...python-v0.33.0)

---
updated-dependencies:
- dependency-name: lancedb
  dependency-version: 0.33.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/pip/lancedb-lt-0.34.0 branch from e6ddf18 to 810bae6 Compare June 8, 2026 16:26
@mtauraso

mtauraso commented Jun 8, 2026

Copy link
Copy Markdown
Member

@copilot Read the comment above the removed line in this file, examine and understand the test results, and go read the relevant parts of the code to tell me if this should be merged, or if more changes are required before we can merge this without breaking users.

Copilot AI commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

@copilot Read the comment above the removed line in this file, examine and understand the test results, and go read the relevant parts of the code to tell me if this should be merged, or if more chan...

This should not be merged yet.

I checked the current CI and the relevant code paths:

  • The docs workflow is failing in docs/notebooks/convert_inference_results_to_pandas.ipynb at df = table.to_pandas() with AttributeError: 'LanceDataset' object has no attribute 'to_pandas' under the updated dependency set.
  • The comment above the changed line in pyproject.toml is still valid: the NaN regression issue (lancedb issue 3153) is still open.
  • Hyrax has explicit round-trip tests for NaN/Inf result tensors (tests/hyrax/test_result_dataset.py::test_roundtrip_fidelity), so relaxing to <0.34.0 without additional compatibility work risks breaking real user outputs.

Recommendation: require more changes before merge (either keep <0.30.0, or add compatibility fixes/pins plus tests proving NaN handling and pandas conversion work with the newer lancedb stack).

Copilot AI commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

@copilot Read the comment above the removed line in this file, examine and understand the test results, and go read the relevant parts of the code to tell me if this should be merged, or if more chan...

Specifically, I’d require these compatibility updates before merging this bump:

  1. Fix the notebook/API break for newer lancedb

    • Update docs/notebooks/convert_inference_results_to_pandas.ipynb so conversion does not rely on the now-broken table.to_pandas() path in this version combination.
    • Use a version-compatible conversion path (e.g., through Arrow/table object) and verify docs build passes.
  2. Prove NaN/Inf safety with the upgraded range

    • Keep/add explicit regression coverage around Hyrax result writing/reading with NaN, Inf, -Inf, -0.0 (the behavior called out in the comment above the dependency line).
    • Ensure this passes with the resolved dependency set from <0.34.0.
  3. Align transitive Lance stack compatibility

    • Confirm and pin a known-good combination of lancedb, lance-namespace, and pylance for this range (right now we already have a protective lance-namespace < 0.7.0 cap because of prior breakage).
    • Add/adjust tests for that exact combo so future bumps fail fast.
  4. Re-run CI checks that cover user-facing behavior

    • At minimum: docs build (nbsphinx notebook execution) and LanceDB result dataset tests.

If we don’t want to do that work in this PR, we should keep the current <0.30.0 cap and close this dependency bump.

@mtauraso

Copy link
Copy Markdown
Member

I've opened #945 to try to address this (and the other related dependabot PR #937) Closing this one.

@mtauraso mtauraso closed this Jun 11, 2026
@dependabot @github

dependabot Bot commented on behalf of github Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot
dependabot Bot deleted the dependabot/pip/lancedb-lt-0.34.0 branch June 11, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants