Skip to content

Fix the types for cite_function - #41

Merged
jeremykubica merged 3 commits into
mainfrom
method_types
Mar 19, 2026
Merged

jeremykubica merged 3 commits into
mainfrom
method_types

Conversation

@jeremykubica

Copy link
Copy Markdown
Contributor

Restructure the decorators to use more standard notation (forced keyword args) and improve types of returned function.

@jeremykubica
jeremykubica requested a review from mtauraso March 18, 2026 20:19
@github-actions

github-actions Bot commented Mar 18, 2026 •

Copy link
Copy Markdown
Before [5e23c4d] After [a7c8acc] Ratio Benchmark (Parameter)
4.56±0.09μs 4.79±0.01μs 1.05 benchmarks.time_create_function
507±2ns 511±3ns 1.01 benchmarks.time_instantiate_class
306±1ns 307±0.9ns 1 benchmarks.time_call_function
1.53±0.01μs 1.48±0.01μs 0.97 benchmarks.time_cite_module
51.8±2ns 48.9±0.09ns 0.94 benchmarks.time_call_function_untracked

Click here to view all benchmarks.

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov

codecov Bot commented Mar 18, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.61%. Comparing base (5e23c4d) to head (ab3ea20).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/citation_compass/citation.py 85.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
- Coverage   94.58%   93.61%   -0.97%     
==========================================
  Files           5        5              
  Lines         277      282       +5     
==========================================
+ Hits          262      264       +2     
- Misses         15       18       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mtauraso mtauraso left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremykubica
jeremykubica merged commit cb97d29 into main Mar 19, 2026
8 of 10 checks passed
@jeremykubica
jeremykubica deleted the method_types branch March 19, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants