This repository was archived by the owner on Jun 1, 2022. It is now read-only.
Repository navigation
This repository was archived by the owner on Jun 1, 2022. It is now read-only.
Handle GitLab remotes on non-gitlab hosts/domains #76
Description
Thanks for an interesting tool!
For me, the usefulness is a bit limited since our (internal) GitLab server is not named gitlab.foo.bar but instead git.foo.bar, so the heuristics for auto-detecting the GitLab remote does not work
I did the following local tweak which works for me but is rather silly (I have an origin remote which is my personal fork and an upstream remote which is the main repository). If we could find a way to conditionalize this (perhaps with a config parameter or ENV variable), it would be great and increase the usefulness of the tool. Do you have any ideas?
diff --git a/internal/gitutil/gitutil.go b/internal/gitutil/gitutil.go
index c298b1e..c58d867 100644
--- a/internal/gitutil/gitutil.go
+++ b/internal/gitutil/gitutil.go
@@ -193,7 +193,7 @@ func (c *RemoteCollecter) collectTargetByArgs(pInfo *GitLabProjectInfo, project,
func filterHasGitlabDomain(remoteInfos []*git.RemoteInfo) []*git.RemoteInfo {
var gitlabRemotes []*git.RemoteInfo
for _, remoteInfo := range remoteInfos {
- if strings.HasPrefix(remoteInfo.Domain, "gitlab") {
+ if strings.HasPrefix(remoteInfo.Domain, "gitlab") || remoteInfo.Remote == "upstream" {
gitlabRemotes = append(gitlabRemotes, remoteInfo)
}
}Reacted by Declan Valters
Activity
Add prepossessing rule
lighttiger2505 commentedon May 15, 2019
Thanks for the contribution. Your opinion is very informative.
I added the ability to virtually define gitlab domain as a solution. You can try this on the following branch.
#77
The virtual gitlab domain feature adds the domain set in the lab command's configuration file to gitlab remote automatic detection.
For example,
git.foo.bar.jpis not gitlab, but lab command detects it.perlun commentedon May 16, 2019
Thanks @lighttiger2505, much appreciated!
How would this work in the
lab browsescenario when no config file exists from beforehand? I think it would be great to be able do something likelab browse --remote upstreamor similar, to let it auto-create the config based on the named remote.What do you think? Just trying to make this feature as easy as possible for people to use.
[-]Handle GitLab remotes not named [/-][+]Handle GitLab remotes on non-gitlab domains [/+][-]Handle GitLab remotes on non-gitlab domains [/-][+]Handle GitLab remotes on non-gitlab hosts/domains [/+]