fix(gossipsub): avoid quadratic send-queue scan on IDONTWANT - #6661
Merged
mergify[bot] merged 1 commit intoOct 3, 2026
Merged
Conversation
Contributor
Merge Queue Status
This pull request spent 13 seconds in the queue, including 2 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Queue::remove_data_messages, which runs for every received IDONTWANT, checked each queued message against the received ids withmessage_ids.contains(..). Handling one IDONTWANT therefore cost O(queue × ids). This looks the ids up in aHashSetinstead, so the cost is O(queue + ids). Behaviour is unchanged.The linear search came in with the send-queue rewrite in #6175.
Also adds a test that a received IDONTWANT removes the listed messages from the peer's send queue, which no existing test covered.
AI Assistance Disclosure
Tools used: Claude Code
Attestation:
Notes & open questions
In a local release build, one call with a full queue (5000, the default
connection_handler_queue_len) and 5000 ids took ~47 ms before this change and ~0.16 ms after.Two related changes we can open as follow-ups if you want them:
MaxIDontWantMessages. This would add a config option.Change checklist