Linux wheels builder: update patchelf - #728
Open
gelzinyte wants to merge 1 commit into
Open
Conversation
Member
|
Thanks! Will be happy to merge this, but currently the wheel building is breaking in CI. Could you take a look when you have time? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into issue #719 too, which seems to be due to manylinux2014 shipping with an older patchelf, which is incompatible with glib >= 2.36 where everything together made gap_fit segfault, though silently. Updating to patchelf >=0.17 seems to have fixed it for me locally.
I have also added a test call for gap_fit and quip, which might catch similar issues in the future.