Skip to content

why delete chamfer from options? - #1092

Open
itgoldman wants to merge 1 commit into
liabru:masterfrom
itgoldman:master
Open

why delete chamfer from options?#1092
itgoldman wants to merge 1 commit into
liabru:masterfrom
itgoldman:master

Conversation

@itgoldman

@itgoldman itgoldman commented Mar 5, 2022

Copy link
Copy Markdown

deleting properties from options prevents user from passing same options to several bodies.

@wilcooo

wilcooo commented Nov 15, 2023

Copy link
Copy Markdown

I agree that this is weird. The reasoning might be that we don't want/need the chamfer property on the created body (and a body clones all the options properties). However, Body.create will always create a chamfer property anyway, set to null... This property doesn't seem to be used anywhere, it might be just there to make the linter happy.

To make this consistent, this PR should be merged or chamfer should be deleted from the "default" body options in Body.create.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants