Skip to content

Add complete typing stubs for pglast v8#191

Merged
lelit merged 1 commit into
lelit:v8from
alexmac:alex/v8-typing-stubs
Jun 2, 2026
Merged

Add complete typing stubs for pglast v8#191
lelit merged 1 commit into
lelit:v8from
alexmac:alex/v8-typing-stubs

Conversation

@alexmac

@alexmac alexmac commented May 24, 2026

Copy link
Copy Markdown

Hi - I'd like to get more extensive type stubs into pglast, Since I've not contributed to this project before please let me know if I'm on the right path here, or if you want a completely different approach

@lelit

lelit commented May 25, 2026

Copy link
Copy Markdown
Owner

Thank you, seems good. OTOH, I'm (veeery slooowly) trying to improve the plpgsql support that libpg_query added, and I really do not know whether I will consider/merge this before or after that.... but I eventually do!

@lelit

lelit commented May 25, 2026

Copy link
Copy Markdown
Owner

Please try to rebase on current v8, the (main) CI error should solve.

@alexmac
alexmac force-pushed the alex/v8-typing-stubs branch from d49f1fd to f16b403 Compare May 25, 2026 17:29
@lelit

lelit commented Jun 1, 2026

Copy link
Copy Markdown
Owner

Hi Alex, I'm not sure if that last commit, "Fix typehint runtime probes in CI" is actually needed, after commit 24c9b19. Can you clarify please?

@lelit

lelit commented Jun 1, 2026

Copy link
Copy Markdown
Owner

I merged v7 into v8 and pushed the result. Merging this comes next.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (v8@0c7f112). Learn more about missing BASE report.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@         Coverage Diff          @@
##             v8    #191   +/-   ##
====================================
  Coverage      ?   0.00%           
====================================
  Files         ?      23           
  Lines         ?    7378           
  Branches      ?       0           
====================================
  Hits          ?       0           
  Misses        ?    7378           
  Partials      ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Generate stubs for AST, enum, keyword, and printer modules, add handwritten stubs for public modules, and wire stub generation and package data into the build.

Add focused ty and mypy coverage for AST fields, parser results, streams, printers, and importable public modules.
@alexmac
alexmac force-pushed the alex/v8-typing-stubs branch from 1d878c7 to 8857f0e Compare June 1, 2026 17:54
@alexmac

alexmac commented Jun 1, 2026

Copy link
Copy Markdown
Author

Hi Alex, I'm not sure if that last commit, "Fix typehint runtime probes in CI" is actually needed, after commit 24c9b19. Can you clarify please?

yeah, I've reworked it to avoid the need for this

lelit added a commit that referenced this pull request Jun 2, 2026
For some reason I could not (yet) figure out, after the merge of PR #191
the coverage report started to emit "No data was
collected (no-data-collected)", effectively listing all sources with 0%
coverage...
@lelit
lelit merged commit 0929472 into lelit:v8 Jun 2, 2026
8 checks passed
@lelit

lelit commented Jun 2, 2026

Copy link
Copy Markdown
Owner

Thanks a lot, I merged this into v8, with a couple of minor tweaks on top.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants