Chore: Desktop: Use SCSS instead of styled-components for plugin dialogs and toolbar buttons - #11189
Merged
laurent22 merged 2 commits intoOct 11, 2024
Conversation
personalizedrefrigerator
added a commit
to personalizedrefrigerator/joplin
that referenced
this pull request
Oct 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request migrates several components away from
styled-componentsand to RCSS. These changes were originally made as a part of #11181, but no longer seem necessary for that PR to work. As such, these migrations have been moved out of #11181 and into a separate pull request.Note
RSCSS is the styling method described in readme/dev/spec/desktop_styling.md
Testing -- Screenshot comparison
Dark mode
Light mode
Note: Before and after screenshots are in different profiles with different notes.