Add ML-DSA post-quantum signature support (RFC 9964)#384
Merged
Conversation
simo5
requested changes
Jul 20, 2026
simo5
left a comment
simo5
left a comment
Member
There was a problem hiding this comment.
Just some minor nitpicks but otherwise looks good overall.
Are there any test vectors in RFC 9964?
If so I would like to have them in the test suite, if not, we should find some to verify that the code does the right thing.
rjeffman
force-pushed
the
add-ml-dsa-rfc9964
branch
from
July 20, 2026 17:48
ca278eb to
1e3afdc
Compare
Collaborator
Author
|
Due to the size of the test vectors, I moved all ML-DSA related tests to |
rjeffman
force-pushed
the
add-ml-dsa-rfc9964
branch
from
July 20, 2026 17:56
1e3afdc to
ba33672
Compare
simo5
approved these changes
Jul 20, 2026
simo5
left a comment
simo5
left a comment
Member
There was a problem hiding this comment.
Just a nit, otherwise this looks good to me.
Implement the AKP (Algorithm Key Pair) key type and ML-DSA-44, ML-DSA-65, ML-DSA-87 signing algorithms per IETF RFC 9964. Requires python-cryptography >= 49.0.0. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Rafael Guterres Jeffman <rjeffman@redhat.com>
Python Cryptography 49+ requires Python 3.9 or later. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Rafael Guterres Jeffman <rjeffman@redhat.com>
rjeffman
force-pushed
the
add-ml-dsa-rfc9964
branch
from
July 20, 2026 18:56
ba33672 to
e49cb16
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the AKP (Algorithm Key Pair) key type and ML-DSA-44, ML-DSA-65, ML-DSA-87 signing algorithms per IETF RFC 9964. Requires python-cryptography >= 49.0.0.
As python-cryptography 49+ requires Python 3.9+, the support for Python 3.8 in dropped, and tests for Python 3.12, 3,13 and 3,14 were added.