Skip to content

Speedup improvements: faster svd and better stencils - #39

Open
larsblatny wants to merge 5 commits into
masterfrom
fast-svd
Open

larsblatny wants to merge 5 commits into
masterfrom
fast-svd

Conversation

@larsblatny

@larsblatny larsblatny commented Sep 9, 2026 •

Copy link
Copy Markdown
Owner

This PR does the following

  • replaces the eigen SVD with a tailored SVD
  • reducing the stencil for the particle grid interpolation depending on the spline
  • makes cubic spline possible when use_sparse=true
  • adds a test for MUSL and Sparse MPM (because these are affected by the above changes)
  • improves N-R scheme for viscous models

This does not change any documentation for the user, hopefully they will only experience a faster execution.

@larsblatny

Copy link
Copy Markdown
Owner Author

@Yidong-ZHAO I made some changes to the sparse implementation to make it work for cubic spline. Would you mind having a quick look at g2p and p2g in case I messed something up?

@atpellet atpellet closed this Sep 10, 2026
@atpellet atpellet reopened this Sep 10, 2026
@atpellet

Copy link
Copy Markdown
Collaborator

(Sorry, I misclicked and closed the PR, I opened it again. i hope it did cause any issue)

@larsblatny larsblatny changed the title Fast svd Speedup improvements: faster svd and better stencils Sep 10, 2026
@Yidong-ZHAO

Copy link
Copy Markdown
Contributor

@Yidong-ZHAO I made some changes to the sparse implementation to make it work for cubic spline. Would you mind having a quick look at g2p and p2g in case I messed something up?

Hi @larsblatny, I had a quick look and I don't see any problems. Basically you just need to change the base and stencil as you have done.

@larsblatny

Copy link
Copy Markdown
Owner Author

@Yidong-ZHAO thank you!

@larsblatny

Copy link
Copy Markdown
Owner Author

Hi everyone, I added another feature (the latest commit about N-R schemes) to this PR. Perhaps it should have been a separate PR as it is only partially related to the rest of this PR. If so I'm very sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants