Skip to content

Relax tests for NUMERICAL_ERROR or OTHER_ERROR #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
odow wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Relax tests for NUMERICAL_ERROR or OTHER_ERROR #1010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b604ee
Relax tests for NUMERICAL_ERROR or OTHER_ERROR
odow Jul 20, 2026
e8d51f0
Add note to the changelog
odow Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ PowerModels.jl Change Log
=========================

### Staged
- Relax tests to allow `OTHER_ERROR` (#1010)

### v0.21.6
- Update to JSON@1 (#986)
Expand Down
6 changes: 3 additions & 3 deletions test/pf-native.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ end
@test isapprox(bus_qg_nlp[i], bus_qg_nls[i]; atol = 1e-6)
end
else
@test result["termination_status"] == NUMERICAL_ERROR
@test result["termination_status"] in (NUMERICAL_ERROR, OTHER_ERROR)
end

end
Expand Down Expand Up @@ -456,7 +456,7 @@ end
@test isapprox(bus_qg_nlp[i], bus_qg_nls[i]; atol = 1e-6)
end
else
@test result["termination_status"] == NUMERICAL_ERROR
@test result["termination_status"] in (NUMERICAL_ERROR, OTHER_ERROR)
end
end
@testset "5-bus case, flat_start" begin
Expand All @@ -482,7 +482,7 @@ end
@test isapprox(bus_qg_nlp[i], bus_qg_nls[i]; atol = 1e-6)
end
else
@test result["termination_status"] == NUMERICAL_ERROR
@test result["termination_status"] in (NUMERICAL_ERROR, OTHER_ERROR)
end
end
@testset "5-bus case, in-place and nsolve method parameter" begin
Expand Down
2 changes: 1 addition & 1 deletion test/pf.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
if result["termination_status"] == LOCALLY_SOLVED
@test isapprox(result["objective"], 0; atol = 1e-2)
else
@test result["termination_status"] == NUMERICAL_ERROR
@test result["termination_status"] in (NUMERICAL_ERROR, OTHER_ERROR)
end
end
@testset "5-bus asymmetric case" begin
Expand Down