test(index): serialize spill-sort tests - #8892
Merged
Merged
Conversation
github-actions
Bot
added
A-index
Xuanwo
marked this pull request as ready for review
August 31, 2026 09:04
BubbleCal
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Plain
cargo testrunslance-indextests in a single process. Spill-enabled index builds therefore share the cached 150 MiB DataFusion memory pool, and concurrent 40 MiBExternalSorterMergereservations can exhaust it. This caused the Linux ARM main job to fail in an otherwise unrelated JSON index test.Change
Put all 15 spill-sort tests in the named
LANCE_DF_SPILL_POOLserial_testresource group. This preserves the production memory-pool configuration while keeping unrelated tests parallel, and replaces the JSON-only mutex with one shared test resource.This supersedes the Rust test-isolation portion of #8819. That PR currently conflicts and also bundles the already-landed Python NaN fix.
Validation
cargo test -p lance-index --lib --features geo -- --test-threads=16(3 consecutive runs, 1191 passed / 0 failed each)cargo clippy --all --tests --benches -- -D warningscargo fmt --all -- --check