fix(linalg): make SIMD slice conversions baseline-safe - #8874
Open
lance-gatefixer[bot] wants to merge 1 commit into
Open
fix(linalg): make SIMD slice conversions baseline-safe#8874lance-gatefixer[bot] wants to merge 1 commit into
lance-gatefixer[bot] wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The raw unaligned-register reads fix the safe constructor and scalar-gather load boundary while preserving exact lane data. Letting the compiler legalize the same bit copy for the caller baseline is preferable to per-load runtime detection because baseline builds stay safe and AVX-enabled callers retain a branch-free vector load.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The safe
Fromimplementations delegated toSIMD::load_unaligned, whose x86_64 arms directly called AVX load intrinsics. A downstream generic x86_64 build could therefore reach an AVX instruction on a host that does not support AVX. Reading the register representation as plain unaligned data lets LLVM select instructions from the caller's actual CPU baseline instead.Validation
RUSTFLAGS='-C target-cpu=x86-64-v2'focused release tests underqemu-x86_64 -cpu Nehalemcargo test -p lance-linalg --lib(460 passed, 1 ignored)cargo fmt --all -- --checkcargo clippy --all --tests --benches -- -D warningsFixes #8872