fix(linalg): validate hamming batch layout - #8873
Open
lance-gatefixer[bot] wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
✅ Gate recommendation: approve.
This fixes malformed Hamming batch handling at the public primitive with the same release-active layout contract used by L2 and Dot. The regression test covers the silent truncation path, and valid-call behavior and the public API remain unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
hamming_distance_batchguarded its layout preconditions with debug-only assertions. Optimized builds therefore letchunks_exactdiscard an incomplete trailing vector and return fewer distances, allowing K-means to rank an incomplete centroid set.Validation
cargo test --release -p lance-linalg test_hamming_distance_batch_rejects_partial_vectorcargo test -p lance-linalg --libcargo test -p lance-linalg --doccargo fmt --all -- --checkcargo clippy --all --tests --benches -- -D warningsFixes #8871