fix(compaction): avoid stranded remainder fragments - #8513
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Author
|
Addressed in 5a9234d: planned row-group sizes are now generated and consumed lazily by the shared chunker, preserving the streaming memory bound. The chunker regression verifies that no sizes are consumed at construction and that sizes advance only as chunks are read. |
Contributor
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The merged revision retains balanced Stable and Legacy compaction boundaries: planner-sized tasks avoid stranded remainders, while byte-limited and oversized rewrites replan remaining rows within the target-scale count. Cleanup and row-ID/index remapping behavior remain preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The planner already groups adjacent small fragments into tasks with approximately
target_rows_per_fragmentrows. Execution applied that target again as a hardmax_rows_per_file, so each task above the target produced a full fragment followed by a small remainder that could become isolated. Removing the cap solely based on source-fragment count then let an indivisible oversized source collapse into one arbitrarily large output.The revised executor computes the output count from logical surviving rows and balances the tail across that count. Planner-sized tasks still produce one output, while genuinely oversized tasks remain target-scale.
Validation
cargo test -p lance --lib dataset::optimize::tests(123 passed)cargo fmt --allcargo clippy --all --tests --benches -- -D warningsmake installandmake buildfrompython/uv run pytest python/tests/test_scalar_index.py::test_zonemap_index_remappinguv run make lintFixes #8506