fix(index): remap ZoneMap search results - #8512
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Blocked: the current-head Remote head |
There was a problem hiding this comment.
✅ Gate recommendation: approve.
All reviewed false-negative paths are now closed. Deferred-remap search and consolidation stay in the live address domain, exact null bitmaps drive transformed counts, and ambiguous legacy singleton statistics fail safely, including Decimal zones with missing extrema.
Summary
Root cause
ZoneMap retained physical row addresses from index creation. Deferred-remap compaction moved those rows and supplied a fragment-reuse remapper when the index was loaded, but ZoneMap search never applied it. The exact null bitmap therefore returned stale addresses without a refinement filter and silently dropped live rows.
Validation
cargo test -p lance test_read_zonemap_index_with_defer_index_remap -- --nocapturecargo test -p lance-index scalar::zonemap::testscargo fmt --all -- --checkcargo clippy --all --tests --benches -- -D warningsgit diff --checkFixes #8504