Skip to content

test: cover managed backfill commits on rest-dir - #782

Open
hfutatzhanghb wants to merge 3 commits into
lance-format:mainfrom
hfutatzhanghb:codex/managed-versioning-rest-test-coverage
Open

test: cover managed backfill commits on rest-dir#782
hfutatzhanghb wants to merge 3 commits into
lance-format:mainfrom
hfutatzhanghb:codex/managed-versioning-rest-test-coverage

Conversation

@hfutatzhanghb

Copy link
Copy Markdown
Contributor

Summary

  • Add an opt-in managed-versioning mode to the local REST directory namespace server.
  • Forward the mode through make docker-test and the pytest REST fixture.
  • Run the ADD COLUMNS and UPDATE COLUMNS backfill tests in a separate managed rest-dir Docker invocation so existing REST search tests keep their current server behavior.

Context

Follow-up to #772 and #772 (comment).

The existing backfill tests were REST-compatible, but no CI job selected them on rest-dir and the default directory adapter reported managedVersioning=false. The dedicated invocation enables both manifest_enabled and table_version_tracking_enabled, matching the managed-versioning setup covered by lance-core 11.0.0-beta.10.

Validation

  • ./mvnw spotless:check -pl lance-spark-3.5_2.13 -am -DskipTests
  • Standalone javac compilation of LanceRestDirNamespaceServer.java
  • Python AST and workflow YAML parsing
  • Pytest collection confirms exactly two managed backfill tests on rest-dir
  • make -n docker-test confirms the managed-versioning flag reaches the container

The local host has no Docker CLI and its x86_64 JVM cannot load the available macOS JNI artifact, so the managed REST round-trip is delegated to the new Ubuntu Docker CI step.

@github-actions github-actions Bot added the chore Features related to test, build, style improvements label Aug 25, 2026
lance-gatekeeper[bot]

This comment was marked as outdated.

@lance-gatekeeper lance-gatekeeper Bot added the K-changes Latest Gatekeeper recommendation requests changes. label Aug 25, 2026
@lance-gatekeeper lance-gatekeeper Bot removed the K-changes Latest Gatekeeper recommendation requests changes. label Aug 25, 2026
lance-gatekeeper[bot]

This comment was marked as outdated.

@lance-gatekeeper lance-gatekeeper Bot added the K-changes Latest Gatekeeper recommendation requests changes. label Aug 25, 2026
@lance-gatekeeper lance-gatekeeper Bot removed the K-changes Latest Gatekeeper recommendation requests changes. label Aug 25, 2026

@lance-gatekeeper lance-gatekeeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gate recommendation: approve.

Both prior findings are fixed. The managed REST tests now distinguish namespace commits from direct dataset commits, and workflow filtering covers the Java and Scala production paths that control managed backfills.

@lance-gatekeeper lance-gatekeeper Bot added the K-approved Latest Gatekeeper recommendation permits acceptance. label Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Features related to test, build, style improvements K-approved Latest Gatekeeper recommendation permits acceptance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant