fix!: preserve unindexed fragments during zonemap pruning - #754
Open
ddupg wants to merge 2 commits into
Open
Conversation
ddupg
marked this pull request as ready for review
August 10, 2026 12:27
ddupg
force-pushed
the
fix/ddu-305-zonemap-partial-coverage
branch
from
August 24, 2026 06:23
7d1b88c to
c7c57d5
Compare
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The rebased implementation preserves the prior result. Resolving the LanceRef into the scan plan and passing that resolved reference to workers keeps live-fragment discovery, zonemap statistics, split planning, and reads on the same dataset snapshot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Zonemap stats only describe indexed fragments. After an append, treating the returned stats as complete could drop the new fragment before Lance scans it. The same assumption could advertise KeyGroupedPartitioning without a trustworthy key for every live fragment.
Testing