feat: support OPTIMIZE INDEX SQL - #745
Conversation
|
@majin1102 Hi, I didn't noticed we have a PR already, and I created my own version #755, do you plan to continue to work on this? Thanks |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Sorry for the late reply. This PR is now ready for review, and your feedback would be very welcome. There are also a few related issues we can look into together:#744, #750 |
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The two previously identified state-transition failures are closed. Empty MemWAL catch-up commits are handled as zero work, and this revision consumes Lance Core 12.0.0-beta.14, which includes the authoritative concurrent drop/maintenance conflict fix from lance#8984. The accompanying Namespace response adaptations preserve current connector behavior across the exercised Spark versions.
Please mark this PR with the breaking-change label.
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The targeted optimize-index path still consumes Core’s authoritative concurrent drop/maintenance guard, and this revision completes that Core 12 migration by declaring both position-delta transactions as whole-row rewrites. That matches their physical fragment replacement and Core conflict contract; Spark 3.5 delete, update, and merge coverage passes, and the Spark 3.4 source variant compiles.
Please mark this PR with the breaking-change label.
|
@hamersaw @jackye1995 @zhangyue19921010 This PR is ready for review, please take a look when you have time |
Summary
ALTER TABLE ... OPTIMIZE INDEXSQL supportDataset.optimizeIndices()on the drivernum_indices_to_merge; when omitted, leave merge policy to Lance CoreSize-tiered parameters are tracked separately in #744.
Closes #743
Testing
./mvnw spotless:applyOptimizeTest,LanceSqlExtensionsAstBuilderTest, andBranchDDLTest(63 tests)OptimizeTest,LanceSqlExtensionsAstBuilderTest, andBranchDDLTest(65 tests)