chore: bump k8s client libraries and controller-runtime to v0.35.x line#401
chore: bump k8s client libraries and controller-runtime to v0.35.x line#401anishbista60 wants to merge 3 commits into
Conversation
3196b75 to
04ff22b
Compare
|
Work on progess. |
| endif | ||
|
|
||
| GOLANGCILINT_VERSION ?= v1.60.1 | ||
| GOLANGCILINT_VERSION ?= v2.12.2 |
There was a problem hiding this comment.
This is required for golang version 1.26.0
|
Blocked by #403 |
Signed-off-by: anish bista <anishbista053@gmail.com>
Signed-off-by: anish bista <anishbista053@gmail.com>
|
I'm not sure security/synk CI is failing. |
Signed-off-by: anish bista <anishbista053@gmail.com>
There was a problem hiding this comment.
1 issue found and verified against the latest diff
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".golangci.yml">
<violation number="1" location=".golangci.yml:138">
P1: Exclusion rule references `exportloopref`, which was removed as a linter in golangci-lint v2. The `exportloopref` check was merged into `govet` and no longer exists as a standalone linter. This will either cause a configuration parsing error or be silently ignored as dead config.
Remove `exportloopref` from the exclusion linters list. If the loopvar capture check is still needed for older Go versions, reference `govet` instead.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
| - errcheck | ||
| - dupl | ||
| - gosec | ||
| - exportloopref |
There was a problem hiding this comment.
P1: Exclusion rule references exportloopref, which was removed as a linter in golangci-lint v2. The exportloopref check was merged into govet and no longer exists as a standalone linter. This will either cause a configuration parsing error or be silently ignored as dead config.
Remove exportloopref from the exclusion linters list. If the loopvar capture check is still needed for older Go versions, reference govet instead.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .golangci.yml, line 138:
<comment>Exclusion rule references `exportloopref`, which was removed as a linter in golangci-lint v2. The `exportloopref` check was merged into `govet` and no longer exists as a standalone linter. This will either cause a configuration parsing error or be silently ignored as dead config.
Remove `exportloopref` from the exclusion linters list. If the loopvar capture check is still needed for older Go versions, reference `govet` instead.</comment>
<file context>
@@ -1,215 +1,147 @@
+ - gofmt
+ - goimports
+ settings:
+ gofmt:
+ simplify: true
+ exclusions:
</file context>
Tracking issue: #kubevela/kubevela#7238
Summary
v0.31.10→v0.35.6:k8s.io/apik8s.io/apimachineryk8s.io/apiserverk8s.io/client-gok8s.io/component-basek8s.io/apiextensions-apiserversigs.k8s.io/controller-runtimefromv0.19.1→v0.23.3go.modto Go1.25v1.35.x, targeting more runway ahead of upstreamv1.37Includes minor fallout fixes required by the bump:
logging_test.go: patch fakePods.GetLogsviaApplyMethodFunc(fake type is now unexported in client-go)credentials_test.go: fix expectation —client.Get()never populatesTypeMeta, now correctly reflected by the fake clientS3Backend.HCL: switched to pointer receiver to match its other methods (recvcheck lint finding)Test plan
Summary by cubic
Upgrade Kubernetes client libraries to v0.35.6 and
sigs.k8s.io/controller-runtimeto v0.23.3, adopt Go 1.25 across builds/CI, and refresh kind-based e2e to Kubernetes 1.35. Migrates linting togolangci-lintv2 with a new v2 config.Dependencies
k8s.io/{api,apimachinery,apiserver,client-go,component-base,apiextensions-apiserver}: v0.31.10 → v0.35.6sigs.k8s.io/controller-runtime: v0.19.1 → v0.23.3sigs.k8s.io/yaml: v1.4.0 → v1.6.0;github.com/go-logr/logr: v1.4.3;github.com/google/go-cmp: v0.7.0;github.com/onsi/gomega: v1.38.2;github.com/stretchr/testify: v1.11.1;github.com/spf13/pflag: v1.0.9golang:1.25.12-alpinekindest/node:v1.35.5golangci-lintv2.12.2;.golangci.ymlmigrated to v2 schema with additional lintersBug Fixes
Pods.GetLogsviaApplyMethodFunc(fake type now unexported inclient-go)TypeMetafromclient.Get()S3Backend.HCL: use pointer receiver; backend reflection usesreflect.PointerWritten for commit 85acea9. Summary will update on new commits.