add protobuf definition and generated Golang code which is buildable with TinyGo - #7
add protobuf definition and generated Golang code which is buildable with TinyGo#7sanposhiho wants to merge 2 commits into
Conversation
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
the
size/XXL
|
@sanposhiho: GitHub didn't allow me to request PR reviews from the following users: codefromthecrypt. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Maybe you can add a test that shows hot to do the following flow? This will help make sure it still works. The test may need to be in the plugin module, in order to avoid leaking v1 deps to the guest.
|
codefromthecrypt
left a comment
codefromthecrypt
left a comment
There was a problem hiding this comment.
Feel free to merge and/or push commits to my branch.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: codefromthecrypt, sanposhiho The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I made notes on #6 and not sure how much of #7 (comment) is needed. Basically, first thing is to make sure we can build tinygo wasm which reads it. For some reason my laptop doesn't respond when trying to build, both 0.27 and dev version of tinygo. |
|
In #6 I added code to generate the MarshallVT functions |
|
It's included in #6. /close |
|
@sanposhiho: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3 participants
What type of PR is this?
/kind feature
What this PR does / why we need it:
add protobuf definition + generated Golang protobuf code which is buildable with TinyGo.
We cannot use the proto definitions in kubernetes/api because it depends on many stuff which aren't buildable with TinyGo.
(Hopefully, it'll be buildable in the future version of TinyGo.)
The protobuf definition is generated from https://github.com/nytimes/openapi2proto with the patch. And use
google.golang.org/protobuf/cmd/protoc-gen-gofor Golang code generation.As you see in ./kubernetes/proto/go.mod, it only depends on
google.golang.org/protobuf, which is buildable with TinyGo.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?