Add promotion-check script for validating promotion requests#77
Open
Jooho wants to merge 1 commit into
Open
Conversation
Script validates open promotion requests in kserve/community against governance criteria by querying kserve/kserve PR activity. Key features: - Separates authored (merged) PR count from reviewed PR count - Filters out bot commands, short comments, and self-reviews - For Approver candidates, measures activity only during reviewer tenure and fails if tenure is less than 3 months - Detects inactive maintainers with 12+ months of no activity - Supports --user mode for individual eligibility checks Outputs markdown (with summary table) or JSON. Signed-off-by: Jooho Lee <jlee@redhat.com>
Jooho
requested review from
cjohannsen-cloudera,
johnugeorge,
lizzzcai,
sivanantha321,
spolti,
terrytangyuan and
yuzisun
as code owners
terrytangyuan
left a comment
terrytangyuan
left a comment
Member
There was a problem hiding this comment.
Should we deprecate the make list-* commands + scripts? Also, we might want to rename this new Python file since it also checks things unrelated to promotion, e.g. inactivity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Script that validates open promotion requests against governance criteria by querying PR activity from kserve/kserve. Runs locally or in GitHub Actions.
Checks authored (merged) PRs and reviewed PRs separately, filters out bot commands and self-reviews, tracks reviewer tenure for Approver candidates, and detects inactive maintainers.
Supports
--usermode for checking individual eligibility before opening a promotion request.Key measurement logic