Skip to content

Test fmin and fmax functions #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kennykos wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Test fmin and fmax functions #419

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions tests/test_ufuncs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,18 @@ def rsqrt_workunit(tid: int, view: pk.View1D[pk.double]) -> None:
view[tid] = rsqrt(view[tid])


@pk.workunit
def fmin_workunit(tid: int, view: pk.View1D[pk.double]) -> None:
nan: pk.double = 1 / 0 - 1 / 0

@JBludau JBludau May 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm ... maybe testing against nan is not the best idea since it compares not equal to itself.
How about using the max/min val for double?

view[tid] = fmin(nan, view[tid])


@pk.workunit
def fmax_workunit(tid: int, view: pk.View1D[pk.double]) -> None:
nan: pk.double = 1 / 0 - 1 / 0
view[tid] = fmax(nan, view[tid])


@pytest.mark.parametrize(
"kokkos_workunit, numpy_ufunc",
[
Expand Down Expand Up @@ -145,6 +157,8 @@ def rsqrt_workunit(tid: int, view: pk.View1D[pk.double]) -> None:
np.reciprocal,
marks=pytest.mark.xfail(reason="see gh-27"),
),
(fmin_workunit, lambda x: np.fmin(np.nan, x)),
(fmax_workunit, lambda x: np.fmax(np.nan, x)),
],
)
def test_1d_unary_ufunc_vs_numpy(kokkos_workunit, numpy_ufunc):
Expand Down
Loading