Skip to content

Remove depreciated workloads for examples/kokkos directory - #395

Open
kennykos wants to merge 10 commits into
mainfrom
kennykos/kokkos-examples
Open

Remove depreciated workloads for examples/kokkos directory#395
kennykos wants to merge 10 commits into
mainfrom
kennykos/kokkos-examples

Conversation

@kennykos

Copy link
Copy Markdown
Collaborator

No description provided.

This allows for portability of examples, as opposed to
enforcing the use of OpenMP execution space
NOTE: lambdas are still broken, should we have a test that checks the
examples for correctness?
@kennykos
kennykos marked this pull request as draft March 12, 2026 16:19
@kennykos

kennykos commented Mar 12, 2026

Copy link
Copy Markdown
Collaborator Author

TODO:

I had Claude write the bash script to
run files in examples/kokkos and ignore
the TypeErrors for lambdas
@kennykos
kennykos marked this pull request as ready for review March 12, 2026 17:09
@kennykos

Copy link
Copy Markdown
Collaborator Author

The new CI is failing with the segfault: Kokkos::abort: Requested Team Size is too large!
when trying to run examples/kokkos/inclusive_scan_team.py.

Some thoughts:

  1. We should catch this error (Requested Team Size is too large!) on the python side
  2. We should have the ability for the user to get the Kokkos auto team size (see https://kokkos.org/kokkos-core-wiki/API/core/policies/TeamPolicy.html#_CPPv4N10TeamPolicy10TeamPolicyE10index_type6AUTO_t10index_type) as an int before a parallel dispatch, so the user can do integer arithmetic. Right now, the user can call pk.AUTO in a parallel dispatch, but this returns a type, not an int.

@kennykos

Copy link
Copy Markdown
Collaborator Author

@IvanGrigorik do you have any idea why the examples workflow is failing with Kokkos::abort: Requested Team Size is too large!? You fixed this in #381, so I'm not sure what's happening.

@IvanGrigorik

Copy link
Copy Markdown
Collaborator

@IvanGrigorik do you have any idea why the examples workflow is failing with Kokkos::abort: Requested Team Size is too large!? You fixed this in #381, so I'm not sure what's happening.

I am pretty sure that this is caused by a lack of execution space. When we execute it on default, it will try to execute it using Serial if I remember correctly. You can test it on your personal computer.

And I don't know how Kokkos will behave with these inputs (Serial + Team size), so check it first, please.

@kennykos

Copy link
Copy Markdown
Collaborator Author

@IvanGrigorik do you have any idea why the examples workflow is failing with Kokkos::abort: Requested Team Size is too large!? You fixed this in #381, so I'm not sure what's happening.

I am pretty sure that this is caused by a lack of execution space. When we execute it on default, it will try to execute it using Serial if I remember correctly. You can test it on your personal computer.

And I don't know how Kokkos will behave with these inputs (Serial + Team size), so check it first, please.

Ok, I'll check back in on this when #429 is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants