Repository navigation
ci(bundle): skip the Codecov upload on PRs from forks - #356
Conversation
GitHub does not hand an OIDC token to pull_request runs whose head repo differs from the base, so the tokenless upload can only fail there, and Bundle Analysis is a required check: every outside contribution was blocked (seen on #346). The upload step now runs on pushes, tags, merge groups and same-repo PRs only, like leak-detect; the build still runs for fork PRs. Signed-off-by: Claude Perrin <klodr@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Conditional Codecov upload .github/workflows/bundle-analysis.yml |
The Codecov upload step runs only for non-pull-request events or pull requests whose head repository matches github.repository. |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Bug fix
Merge Risk: 
9bca5
-
No actionable merge-blocking risk remains in the reviewed workflow change.
Pre-merge checks: 
-
Check name Status Explanation Title check The title uses the allowed citype with the optionalbundlescope. The subject is lowercase, imperative, relevant to the workflow change, has no trailing period, and is 53 characters long.Description check The description directly explains the Codecov upload condition, the fork pull request failure, the workflow behavior, and the validation performed. It is related to the changeset. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Bundle ReportBundle size has no change ✅ |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #356 +/- ##
=======================================
Coverage 99.39% 99.39%
=======================================
Files 35 35
Lines 2320 2320
Branches 691 691
=======================================
Hits 2306 2306
Misses 12 12
Partials 2 2 Continue to review full report in Codecov by Harness.
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Summary
pull_requestruns whose head repo differs from the base, so the tokenless Codecov upload in Bundle Analysis can only fail on a fork PR ("Unable to get ACTIONS_ID_TOKEN_REQUEST_URL"). Bundle Analysis is a required check, so every outside contribution is blocked — seen on fix(search): state zero matches instead of returning an empty text #346.Type
feat— new user-facing feature or toolfix— bug fixdocs— documentation onlyrefactor— no behavior changeperf— performancetest— test-only changeci— CI / workflows / release plumbingchore— deps, build, or other repo-managementsecurity— security-sensitive change (see Security checklist below)Checklist
npm testgreen locally (vitest)npm run buildsucceeds (includestsc --noEmit)npm run lintclean — workflow YAML checked with yaml-lintnpm run format:checkcleanCHANGELOG.mdupdated under[Unreleased](if user-visible)Notes for reviewers
No
pull_request_target, no new permission, no secret exposed to forks: the step is only skipped.