Skip to content

Upgrade to Rails 7.2 - #23

Open
tungleduyxyz wants to merge 2 commits into
masterfrom
upgrade_rails_7.2
Open

Upgrade to Rails 7.2#23
tungleduyxyz wants to merge 2 commits into
masterfrom
upgrade_rails_7.2

Conversation

@tungleduyxyz

@tungleduyxyz tungleduyxyz commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Upgrade the engine to Rails 7.2.

  • Require rails ~> 7.2 in the gemspec
  • Require Ruby >= 3.1.0 (minimum Ruby version for Rails 7.2)

See killbill/killbill-admin-ui#655 for the corresponding kaui engine upgrade.

JRuby CI fix (i18n / Fiber.current)

CI on jruby-9.4.2.0 failed during boot with:

NoMethodError: undefined method `current' for Fiber:Class
Did you mean?  __current__
  initialize at i18n-1.15.2/lib/i18n/config.rb:14

Root cause: i18n 1.15.x switched I18n.config to fiber-based storage. The original 1.15.0 report (ruby-i18n/i18n#735) covered the Fiber[:i18n_config] call breaking CRuby < 3.2; 1.15.1/1.15.2 reworked that but I18n::Config#initialize still calls Fiber.current. JRuby 9.4.2.0 doesn't expose a public Fiber.current (only the internal __current__; the public alias was added in a later 9.4.x release), so any i18n >= 1.15.0 fails at boot on that runtime.

This PR therefore also:

  • Locks i18n to ~> 1.14.0 (1.14.x has no fiber code path, and satisfies activesupport 7.2's i18n >= 1.6, < 2) — matching the existing pins in kaui and kaui-standalone
  • Bumps CI JRuby from 9.4.2.0 to 9.4.15.0 (which provides a proper Fiber.current) — matching kaui's CI

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades the kenui mountable Rails engine to Rails 7.2 and adjusts Ruby/JRuby compatibility constraints to keep CI and runtime boot stable (notably around i18n + Fiber behavior on JRuby).

Changes:

  • Bump the engine’s Rails dependency to ~> 7.2 and set required_ruby_version >= 3.1.0.
  • Add an i18n version pin (currently in the Gemfile) to avoid i18n 1.15.x Fiber-related boot failures on older JRuby.
  • Update GitHub Actions CI JRuby matrix from jruby-9.4.2.0 to jruby-9.4.15.0.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
kenui.gemspec Raises minimum Ruby version and upgrades the engine runtime Rails dependency to 7.2.
Gemfile Pins i18n to 1.14.x and updates the Rails version for development/bundler resolution.
.github/workflows/ci.yml Bumps JRuby used in CI to a version that supports Fiber.current.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread kenui.gemspec
Comment on lines 23 to +26
s.add_dependency 'killbill-assets-ui'
s.add_dependency 'killbill-client'
s.add_dependency 'rails', '~> 7.0'
s.required_ruby_version = '>= 3.1.0'
s.add_dependency 'rails', '~> 7.2'
Comment thread Gemfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants